search

IAU-ADES / ADES-Master

ADES implementation based on a master XML file
26 stars 7 forks source link

Occultations #24

Closed federicaspoto closed 11 months ago

federicaspoto commented 11 months ago

The ADES repository had some problems with the new occultation format.

@stevechesley I wasn't able to recreate the pdfs once I have changed the master xml. How do I do that?

dfarnocchia commented 11 months ago

@federicaspoto Just to make sure I understand, we went from 8 to 9 digits after the decimal point for raStar and decStar, correct? The total number of digits was 12 (just like ra and dec, which are not being changed) and is now increased to 13.

At this point, do we also need to change the deltaRA and deltaDec to allow the same precision? Right now, they can be 9 characters plus the sign. That means a precision of 1e-7 deg, which is coarser than raStar and decStar.

federicaspoto commented 11 months ago

@dfarnocchia yes, that is correct. I can change deltaRA and deltaDec as well.

dfarnocchia commented 11 months ago

@federicaspoto the other option would be to push back with D. Herald and ask him to comply with the current standard. 1e9 deg = 3.6e-6 arcsec, no astrometry is that good so I don't see the need. Unless the goal is to use the star position with full precision from Gaia as identifier.

Either way, deltaRA and deltaDec would need higher precision anyway, to at least match that of ra and dec (up to ~1e-8 deg) or raStar, decStar.

federicaspoto commented 11 months ago

@dfarnocchia I added the required precision to deltaRA and deltaDec. Also, while re-reading your comment, I realized that I need to point out that this change automatically also changes the precision for RA and Dec. This is because of how the variable type is defined in the ades master.