search

IAU-ADES / ADES-Master

ADES implementation based on a master XML file
26 stars 7 forks source link

Add checks on magnitude values. #35

Closed federicaspoto closed 7 months ago

federicaspoto commented 7 months ago

@stevechesley we noticed that people can submit wrong values of magnitudes and they would pass the ADES validation. An example was a submission with a magnitude value of 209 instead of 20.9. Can we add a check on the magnitude as we do for RA or Dec?

(cc @matthewjohnpayne )

stevechesley commented 7 months ago

This was discussed sometime in the distant past, but it seemed hard to put strict bounds on this, taking into account the possibility of close approaches by large asteroids (potentially from a spacecraft), and major efforts to detect extremely faint objects.

A very large asteroid (H=12 mag) at the lunar distance could be V=-1 mag. And I seem to recall that there have been observations reported in the range 27-28mag. What limits would you propose? It seems like -5 mag to +35 mag should be safe for a very long time.

federicaspoto commented 7 months ago

Yes, I agree and I was thinking about something quite large but still meaningful. We could also go up to +40 mag if you want to, otherwise -5 mag to +35 mag looks more than reasonable to me.

stevechesley commented 7 months ago

Resolved with PR #37