IAU-ADES / ADES-Master

ADES implementation based on a master XML file
26 stars 7 forks source link

code, tests & examples for (i) converting XML <-> JSON, & (ii) residuals #43

Closed matthewjohnpayne closed 6 months ago

matthewjohnpayne commented 6 months ago

The changes in this branch are to perform the following

(1) allow conversion between XML <-> JSON files.

(2) provide examples (and validation tests) of ADES files that include RESIDUALS.

matthewjohnpayne commented 6 months ago

@federicaspoto : Thanks for looking at this.

With regards to your comment/questions regarding the format of input/*Residual.xml:

federicaspoto commented 6 months ago

@matthewjohnpayne thank you! About my comment on the formatting, it was about the fields themselves, not the comments. But it is not important. It just looked weird on my screen.

matthewjohnpayne commented 6 months ago

@federicaspoto : no worries. I'm going to leave this open and let @stevechesley have a chance to look at it before I merge anything.

matthewjohnpayne commented 6 months ago

@stevechesley : thanks for adding in the shebangs. I added the pyyaml and xmltodict to the requirements file. I renamed the code to be 'xmltojson', etc For what it's worth, I also added in the future stuff, although I've no idea if there's any value to it anymore. All my tests still pass, so I'm going to go ahead and merge.