search

IAU-ADES / ADES-Master

ADES implementation based on a master XML file
26 stars 7 forks source link

Switch to 8char packed designations for comets #56

Closed stevechesley closed 4 months ago

stevechesley commented 4 months ago

This should address issue #36.

@stevenstetzler please see what I did to your test to separate the comet and asteroid provIDs. Not sure if I broke anything, but it seems to test okay now.

@federicaspoto The way things stand we can safely pack and unpack comet provIDs only if they are 8 characters (plus the leading 4 char for the permID), for example, ....CK03A010 (here blanks are indicated by .s). If the comet has only a 7-char packed provID then we are in trouble since we don't know if the leading character is C/, A/, X/, D/, etc. So the question is, are there any (unnumbered) packed designations in your obs80 exports that do not specify the leading / character, e.g., .....K03A010? Right now these are getting translated with an A/, which might even be correct. I don't know. But if this never can happen it is simpler.

Neglecting the leading character seems to work for for numbered A/ objects. For example, '~abcdK44A010unpacks aspermID=9344431and provID =A/2044 A1`. That's a MP number and comet designation. Which is probably right.

The MPC documentation is a bit fuzzy about whether there can be packed provisional designations without the / character.

stevenstetzler commented 4 months ago

@stevechesley the way you separated out comet and asteroid provIDs looks okay for the test. I don't see the test passing though using the 8-char packed provID for comets. Is this in progress or is a commit missing?

stevechesley commented 4 months ago

OK, so I have too many branches up in that air and can't keep track... The new test_packUtil.py only works with the new packUtil.py with the bug fix on the prog_pack branch on PR #53. So I am adding the updated test_packUtil.py over on that branch and deleting/canceling the comet_pdesig branch and this PR #56.