Some trksubs are considered invalid by the converter from XML to obs80, but they are actually not

IAU-ADES / ADES-Master

ADES implementation based on a master XML file

26 stars 7 forks source link

Some trksubs are considered invalid by the converter from XML to obs80, but they are actually not #58

Closed federicaspoto closed 3 months ago

federicaspoto commented 4 months ago

@stevenstetzler could you please take a look at this PR? This should solve some of the problems we (MPC) were having with trksub. Now the code:

Will use the same regex that it uses in the xsd
If len(trksub)>7, the code will still make the conversion to obs80, but it will print a warning
It now allows the possibility of writing a provid in the trksub field. Thank you!

cc: @stevechesley @matthewjohnpayne

federicaspoto commented 4 months ago

@federicaspoto I think I understand the changes here and was able to review them. I think I spotted an error in the regex, and I made a comment about printing the warning to stdout (stderr is a better place for it).

@stevenstetzler thank you!

federicaspoto commented 4 months ago

@stevechesley or @stevenstetzler if you are happy with the changes and the tests, could you please approve this PR. Otherwise I am happy to make more changes or improve the code, if needed. We need to use the conversion internally for an open Jira ticket. Thank you!

stevenstetzler commented 4 months ago

@federicaspoto I've approved the changes, feel free to merge when ready.

stevechesley commented 4 months ago

I think it is ready to merge, but please look at what I did to new_tests/test_xmltompc80col.py.

federicaspoto commented 3 months ago

@federicaspoto I've approved the changes, feel free to merge when ready.

Thank you!