IAmHughes / giphy-generator

A GitHub Action to generate a gif in a comment on issues and PRs, responding to the command `/giphy <search_term>`. Written in JavaScript.
GNU General Public License v3.0
15 stars 3 forks source link

Awesome new issue! #13

Open IAmHughes opened 3 years ago

IAmHughes commented 3 years ago

This is a bunch of text about what this feature request is.

/giphy just do it

github-actions[bot] commented 3 years ago

send it atlanta braves GIF by MLB

Powered by GIPHY

github-actions[bot] commented 3 years ago

just do it GIF

Powered by GIPHY

IAmHughes commented 3 years ago

/giphy hacker

github-actions[bot] commented 3 years ago

charlie hunnam yes GIF

Powered by GIPHY

IAmHughes commented 3 years ago

Whatever information

/giphy bootcamp

github-actions[bot] commented 3 years ago

Powered by GIPHY

IAmHughes commented 3 years ago

/giphy another one

github-actions[bot] commented 2 years ago

No Sad GIF by Dolly Parton

Powered by GIPHY

rajbos commented 1 year ago

Something seems to be off with the url that is generate, as they are not loading @IAmHughes ?

/giphy roll the dice

github-actions[bot] commented 1 year ago

Rolling Dice Here You Go GIF by Rich The Kid

Powered by GIPHY

rajbos commented 1 year ago

Hmm, seems to be hit or miss:

/giphy scrum agile standup

github-actions[bot] commented 1 year ago

Stand Up Comedy GIF by The Ed Sullivan Show

Powered by GIPHY

IAmHughes commented 1 year ago

Hmm, seems to be hit or miss:

/giphy scrum agile standup

there may be a bug in that it doesn't find results for the gif and I probably am not handling the error Giphy's API throws. Thank you for the info!

rajbos commented 1 year ago

Did you check the actual markdown being generated? I think I have seen links that should work (might have been a different solution).

I'm also thinking if this could be caused by rate limiting on Giphy's end?

IAmHughes commented 1 year ago

Did you check the actual markdown being generated? I think I have seen links that should work (might have been a different solution).

I'm also thinking if this could be caused by rate limiting on Giphy's end?

I'm not really sure if it's a rate limit or something else. The markdown looks correct to me where we're seeing blanks here.

To be honest this was a fun sample project of an example of what you can do with Actions outside of just CI/CD type of tooling. I'm totally open to PRs if you find a specific issue and wanted to contribute, but otherwise I unfortunately have it in a bit of an inactive state in terms of updates and such. If time permits, I wouldn't mind coming back to it.

IAmHughes commented 11 months ago

/giphy ship it

github-actions[bot] commented 11 months ago

internet ship it GIF

Powered by GIPHY