IBDecodable / IBLinter

A linter tool for Interface Builder
MIT License
948 stars 42 forks source link

Specify pod platform #112

Closed giginet closed 5 years ago

giginet commented 5 years ago

Problem

CocoaPods attempt to build for all platforms. (such as watchOS!) It hits the CocoaPods issue.

$ pod lib lint

 -> IBLinter (0.4.17)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - ERROR | [watchOS] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | [watchOS] xcodebuild:  xcodebuild: error: Unable to find a destination matching the provided destination specifier:

[!] IBLinter did not pass validation, due to 1 error.
You can use the `--no-clean` option to inspect any issue.

Description

kateinoigakukun commented 5 years ago

I added COCOAPODS_VALIDATOR_SKIP_XCODEBUILD to avoid this issue before, but this change seems better than that. Could you remove the flag from Makefile? https://github.com/IBDecodable/IBLinter/blob/1953cc85410b299820659fc03070fcbc4dbc37a8/Makefile#L35