IBDecodable / IBLinter

A linter tool for Interface Builder
MIT License
950 stars 40 forks source link

feat: reuse_identifier rule support UICollectionReusableView #152

Closed r-plus closed 4 years ago

r-plus commented 4 years ago

Hi @kateinoigakukun and @phimage.

Latest IBDecodable supported decode feature of UICollectionReusableView. This PR use it to support UICollectionReusableView in reuse_identifier rule.

~NOTE: IBDecodable not yet released as tagged version, I'll change back package dependency files after the release. That is reason I add "WIP" to PR title, but all other work are finished please review except it~ 0.2.0 is not available 👍

Detail changes description

kateinoigakukun commented 4 years ago

Thanks for update! I tagged IBDecodable just now. Could you add test cases in IB for non-violated views to ensure that the linter won't report false positive result?

r-plus commented 4 years ago

@kateinoigakukun Sure :) I just added test cases (fixture resource) for it.

r-plus commented 4 years ago

and thanks to add tag for IBDecodable! switch backed to using version specification.

Remove "WIP" label.

kateinoigakukun commented 4 years ago

Thanks!