search

IBDecodable / IBLinter

A linter tool for Interface Builder
MIT License
950 stars 40 forks source link

Update Commandant to use version instead of branch for compatibility with other packages using Commandant #80

Closed stephanecopin closed 5 years ago

stephanecopin commented 5 years ago

In the current setup, if IBLinter is used in a project via SPM with other tools that uses Commandant (for example SwiftLint):

// swift-tools-version:4.2
import PackageDescription

let package = Package(
    name: "App",
    dependencies: [
      .package(url: "https://github.com/Realm/SwiftLint", from: "0.28.1"),
      .package(url: "https://github.com/stephanecopin/IBLinter", .from("0.4.11")),
    ]
)

The swift build command will fail with the following error:

error: the package iblinter[https://github.com/IBDecodable/IBLinter] @ 0.4.11 contains incompatible dependencies:
    ibdecodable[https://github.com/IBDecodable/IBDecodable.git] @ master
    commandant[https://github.com/Carthage/Commandant.git] @ master

This PR fixes the issue by specifying the latest (as of writing this) version for Commandant, 0.15.0.

I didn't touch IBDecodable as it wasn't an issue for me, but let me know if I should also update it and pin the version to 0.0.2.

kateinoigakukun commented 5 years ago

LGTM Thanks!