search

IBM-Blockchain-Archive / fabric-boilerplate

Get up and running quickly with your own blockchain application!
Apache License 2.0
79 stars 150 forks source link

Upgrade of angular-cli to @angular/cli (Beta 32.3) #39

Closed JohannesBertens closed 7 years ago

JohannesBertens commented 7 years ago

Tests are failing for me, but also pre-update these tests seem to be failing - anyone able to update these?

czar0 commented 7 years ago

Hey @DJBnjack , I have tested your changes, but apparently the client container keeps failing and exiting with the following error:

client_1      | EISDIR: illegal operation on a directory, read
client_1      | Error: EISDIR: illegal operation on a directory, read
client_1      |     at Error (native)
client_1      |     at Object.fs.readSync (fs.js:731:19)
client_1      |     at tryReadSync (fs.js:486:20)
client_1      |     at Object.fs.readFileSync (fs.js:534:19)
client_1      |     at Function.CliConfig.fromConfigPath (/usr/local/lib/node_modules/angular-cli/models/config/config.js:76:18)
client_1      |     at Function.CliConfig.fromProject (/usr/local/lib/node_modules/angular-cli/models/config.js:63:44)
client_1      |     at Object.<anonymous> (/usr/local/lib/node_modules/angular-cli/commands/serve.js:6:33)
client_1      |     at Module._compile (module.js:570:32)
client_1      |     at Object.Module._extensions..js (module.js:579:10)
client_1      |     at Module.load (module.js:487:32)
client_1      |     at tryModuleLoad (module.js:446:12)
client_1      |     at Function.Module._load (module.js:438:3)
client_1      |     at Module.require (module.js:497:17)
client_1      |     at require (internal/module.js:20:19)
client_1      |     at Class.includedCommands (/usr/local/lib/node_modules/angular-cli/addon/index.js:23:16)
client_1      |     at /usr/local/lib/node_modules/angular-cli/ember-cli/lib/models/project.js:316:61
client_1      |     at Array.forEach (native)
client_1      |     at Project.addonCommands (/usr/local/lib/node_modules/angular-cli/ember-cli/lib/models/project.js:315:15)
client_1      |     at Project.eachAddonCommand (/usr/local/lib/node_modules/angular-cli/ember-cli/lib/models/project.js:350:30)
client_1      |     at module.exports (/usr/local/lib/node_modules/angular-cli/ember-cli/lib/cli/lookup-command.js:33:13)
client_1      |     at CLI.<anonymous> (/usr/local/lib/node_modules/angular-cli/ember-cli/lib/cli/cli.js:42:26)
client_1      |     at tryCatch (/usr/local/lib/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:538:12)
client_1      |     at invokeCallback (/usr/local/lib/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:553:13)
client_1      |     at publish (/usr/local/lib/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:521:7)
client_1      |     at flush (/usr/local/lib/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:2373:5)
client_1      |     at _combinedTickCallback (internal/process/next_tick.js:67:7)
client_1      |     at process._tickCallback (internal/process/next_tick.js:98:9)

I am not sure it is something related to possible conflicts between the new angular-cli version you propose and the other modules. We have recently made some changes to branch v2-typescript (now master), so it is also possible this PR should be corrected and reviewed. Please retest your code and let us know. Thanks!

czar0 commented 7 years ago

I will create a new pull request with a stable version of @angular/cli.