i686 architecture not handled

IBM-Blockchain-Archive / fabric-images

Docker images and Docker Compose files for running the Hyperledger fabric

Apache License 2.0

36 stars 50 forks source link

i686 architecture not handled #18

Open kletkeman opened 7 years ago

kletkeman commented 7 years ago

The setup shell script expects only 64 bit architecture, but even on a 64 bit machine it appears the the git shell launched from git desktop sets arch to i686, which is the 32 bit equivalent. So perhaps it would make sense to add it in, as in:

case $arch in "i686") export ARCH_TAG="x86_64-0.6.1-preview" ;; "x86_64") export ARCH_TAG="x86_64-0.6.1-preview" ;;

mrshah-at-ibm commented 7 years ago

Thanks @kletkeman, can you do a PR?

kletkeman commented 7 years ago

I tried, but I don't have permission to push my local changes on a branch ... PR fails.

mrshah-at-ibm commented 7 years ago

@kletkeman You should be able to fork the project and do a PR from your fork. I will do it today, no problem.