search

IBM-Blockchain-Archive / fabric-images

Docker images and Docker Compose files for running the Hyperledger fabric
Apache License 2.0
36 stars 50 forks source link

README for fabric-images is incorrect #20

Closed kletkeman closed 7 years ago

kletkeman commented 7 years ago

The command to set up the environment is shown as

. setup.sh

It should, of course, show a forward slash between the . and the setup.sh, but even that does not actually work, because the export commands for ARCH_TAG only export to sub shells and not to the parent shell, where the docker-compose command is executed next.

Instead, the README should show the following command:

source setup.sh

After that, the Dockerfile is correct and the parent shell knows ARCH_TAG.

dhyey-ibm commented 7 years ago

http://stackoverflow.com/questions/4732200/replacement-for-source-in-sh

. setup.sh and source setup.sh are the same commands.

kletkeman commented 7 years ago

Lol ... ok, you got me ... had not seen that syntax, ever. (There is something to be said or not using the inscrutable shortcuts, but I probably should have known that.)

kletkeman commented 7 years ago

You learn something new every day ...