search

IBM-Blockchain-Archive / fabric-images

Docker images and Docker Compose files for running the Hyperledger fabric
Apache License 2.0
36 stars 50 forks source link

tag latest removed on dockerhub #21

Closed vincentserpoul closed 7 years ago

vincentserpoul commented 7 years ago

this pull request fixes it. https://github.com/IBM-Blockchain/fabric-images/pull/17

that said, I think it would be better to have a defined version instead of a random tag

mrshah-at-ibm commented 7 years ago

This is not the source image name, this is target image name. It is under build tag of compose file. It will use the Dockerfile inside the baseimage folder to build the image.

vincentserpoul commented 7 years ago

try to remove all your docker images and do a docker-compose up. You will see it will try to pull the image with the tag latest.

mrshah-at-ibm commented 7 years ago

It should not. It should build using the ./baseimage folder. Ref: https://docs.docker.com/compose/compose-file/#/build

vincentserpoul commented 7 years ago

ok, I found the issue. On mac, . setenv.sh doesn't work, and it was then not setting the ENV variable and stopping there, complaining about a missing manifest file. ./setenv.sh works... Dumb mistake :/. I will create a small PR to prevent this from happening (it seems I wasn't the only one as there was another issue with the same symptoms)

mrshah-at-ibm commented 7 years ago

@vincentserpoul as you mentioned, the other issue has a solution comment which says . setenv.sh is same as source setenv.sh.

Ref: https://github.com/IBM-Blockchain/fabric-images/issues/20#issuecomment-272246251

Thus a PR is not necessary. Thank you.