search

IBM-Blockchain-Archive / ibm-container-service

IBM Blockchain Platform for Developers on IBM Container Service
Apache License 2.0
89 stars 73 forks source link

Moving to 1.1 fabric #103

Closed dhyey20 closed 6 years ago

dhyey20 commented 6 years ago

Thanks @lvndry for https://github.com/IBM-Blockchain/ibm-container-service/pull/102. I have made some more changes to use the latest couchdb image. And updated a couple of environment variables, along with updating the configtx.yaml to v1.1 level.

lvndry commented 6 years ago

So I can close my PR ?

mrshah-at-ibm commented 6 years ago

yes, we will merge this - it gives you credits for your contributions 😄

lvndry commented 6 years ago

Alright great! :smile: Also I was asked to add the env variable CORE_PEER_GOSSIP_USELEADERELECTION=true and CORE_PEER_GOSSIP_ORGLEADER=false to the peers please add it before merging

lvndry commented 6 years ago

Why am I not mentioned as a contributor?

Le mar. 3 juil. 2018 à 15:34, Mihir Shah notifications@github.com a écrit :

Merged #103 https://github.com/IBM-Blockchain/ibm-container-service/pull/103.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IBM-Blockchain/ibm-container-service/pull/103#event-1714047241, or mute the thread https://github.com/notifications/unsubscribe-auth/AWAtE4IimLB9GTcFMwDXOoi6eHtqwWfEks5uC3L2gaJpZM4UygVR .

mrshah-at-ibm commented 6 years ago

@lvndry I didn't know that "Squash and merge" would do this. It did show you as author on this PR.

image

I apologize. If you want I can revert the commit and we can redo the PR.