nit: Helm Chart uses "ibm-blockchain-*-pvc" for both PV (and PVC) - Githubissues

IBM-Blockchain-Archive / ibm-container-service

IBM Blockchain Platform for Developers on IBM Container Service

Apache License 2.0

89 stars 73 forks source link

nit: Helm Chart uses "ibm-blockchain-*-pvc" for both PV (and PVC) #95

Open DazWilkin opened 6 years ago

DazWilkin commented 6 years ago

Recommend:

Either map names correctly to types
Or (my preference) generalize the names (removing the K8s type) perhaps:
- "shared" or "shared-volume"
- "composer" or "composer-volume"

For both Shared and Composer (although Composer is removed from Chart):

https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/_helpers.tpl#L22

https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/_helpers.tpl#L38

Shared PersistentVolume: https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/shared-pvc.yaml#L6

Shared PersistentVolumeClaim: https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/shared-pvc.yaml#L25