IBM-Blockchain-Archive / ibm-container-service

IBM Blockchain Platform for Developers on IBM Container Service
Apache License 2.0
89 stars 74 forks source link

Helm Chart inconsistent naming results in Services not binding to Pods #96

Open DazWilkin opened 6 years ago

DazWilkin commented 6 years ago

Helm Chart inconsistently uses ibm-blockchain-network.name and ibm-blockchain-network.fullname

E.g. CA Service selects on name == -network.name and app == -network.name https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/blockchain-ca-service.yaml#L15

But CA Deployment name == -network.fullname (!?) and app == -network.name https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/blockchain-ca.yaml#L15

This is true for all of the Deployment-Service pairs and so none of the Services binds to Pods

Recommend: -- Use -network.name or -network.fullname consistently -- -network.name [my preference] is simpler but could result in collisions with multiple deployments !? -- '-network.fullname` is more long-winded but should avoid collisions -- But are collisions likely? Wouldn't it be better to partition by namespaces anyway