search

IBM-Blockchain-Archive / marbles

WARNING: This repository is no longer maintained ⚠️ This repository will not be updated. The repository will be kept available in read-only mode.
Apache License 2.0
1.02k stars 977 forks source link

Event hub not getting disconnected in invoke_cc.js #151

Open venugopv opened 7 years ago

venugopv commented 7 years ago

Eventhub is not getting disconnected in invoke_cc.js invoke_chaincode().

Once after transaction event is notified or failed/timedout, the Eventhub has to be disconnected.

This is leading SSL socket leak (i.e socket which is used to connect Eventhub) and causing NODE.JS app not getting exited properly.

dshuffma-ibm commented 7 years ago

thanks! you are right, it was hanging onto the sockets. sort of fixed in https://github.com/IBM-Blockchain/marbles/commit/d509207cc448699c2a4dda11d33436202e587126 ...

before this "fix" the connections were growing by 2 every invoke. now they are growing by one... i'm not sure where the other connection is coming from, might be sdk? i'll have to revisit this.