search

IBM-Blockchain-Starter-Kit / build-lib

Common scripts for use in Blockchain build pipelines
https://ibm-blockchain-starter-kit.github.io/
Apache License 2.0
4 stars 14 forks source link

Chanincode component may contain folders. #84

Closed rolivieri closed 5 years ago

rolivieri commented 5 years ago

The current implementation leaves behind any folders that exist in the chaincode component. This creates problems when, for instance, installing a chaincode component that uses indexes for CouchDB (for further details see this).

This PR addresses the existing limitation; we are in the middle of an MVP and need this functionality asap.

@jorgedr94 - As we discussed, this is the first PR. In a future PR, we can add the logic for allowing the developer to specify a pattern that specifies which files/folders can be left behind. I have a few ideas on how to implement this; let's discuss them in person.

@jorgedr94 - I need to update the test cases... so still work in progress.

rolivieri commented 5 years ago

@jt-nti I was not aware of issue #67; thanks for sharing that link. I was thinking that I could not be the first person running into this limitation. :) Yes, this PR will certainly fix that problem. As you mentioned above, I still need to address the test cases that are failing. Adding more configuration options such as controlling the contents of the ZIP would be useful. We can certainly tackle that as a separate PR after this one.