search

IBM-Blockchain-Starter-Kit / build-lib

Common scripts for use in Blockchain build pipelines
https://ibm-blockchain-starter-kit.github.io/
Apache License 2.0
4 stars 14 forks source link

Replacing readarray introduced defect #90

Closed rolivieri closed 5 years ago

rolivieri commented 5 years ago

@jt-nti Substituting the invocation of the readarray function introduced an undesired side effect: https://github.com/IBM-Blockchain-Starter-Kit/build-lib/commit/80ae24d3e521d8f83c22cb187af16d543acbbc3d#diff-4232d04ac25a24d9be1857b4a35faf60R53.

Developers now have to ensure that their .govendor_packages does have a newline character in every line. When using the readarray function this is not required. For instance, using the readarray function allows the developer to have a .govendor_packages file without the need to have a newline at the end of the package definition as shown below:

github.com/hyperledger/fabric/core/chaincode/lib/cid@v1.2.1

However, the developer is now forced to ensure their file looks like this instead (see the extra line):

github.com/hyperledger/fabric/core/chaincode/lib/cid@v1.2.1

Can you update the code you added to replace the readarray function so it can handle this situation and avoid forcing the developer to add that extra new line in the .govendor_packages file?