search

IBM-Cloud / logistics-wizard-toolchain

Toolchain configuration files for the logistics-wizard demo
13 stars 15 forks source link

Please use api-key (which is standard) instead of iam-api-key #40

Closed jasmsing closed 6 years ago

l2fprod commented 6 years ago

@jasmsing can you point us to the documentation for this field and why naming it "api-key" makes a difference?

van-ibm commented 6 years ago

Presume this relates to convention used in open toolchain demos: https://github.com/search?p=2&q=org%3Aopen-toolchain+%22api-key%22&type=Code

I tend to favor being more verbose in our naming. "api-key" doesn't connote the IBM Cloud Identity and Access Management api key; we have many api keys for services. There may be 3rd party keys used in the toolchain as well. For clarity, should we not prefix which service the api-key applies?

l2fprod commented 6 years ago

will leave it as-is