search

IBM-Cloud / openwhisk-darkvisionapp

Discover dark data in videos with IBM Watson and IBM Cloud Functions
Other
110 stars 257 forks source link

This allows spaces in CF_ORG and CF_SPACE #65

Closed sdague closed 7 years ago

sdague commented 7 years ago

The pipeline-DEPLOY.sh script was optimistic about assumptions in the CF variables, and didn't take into account ones that might have spaces. This fixes a few of the issues uncovered by bug #54.

l2fprod commented 7 years ago

@sdague I merged this to the test branch but I'm still getting an issue with the Speech to Text callback:

Speech to Text OpenWhisk action is accessible at https://openwhisk.ng.bluemix.net/api/v1/web/myemail@ibm.com_space+with+spaces/vision/speechtotext
....
No local.env found. Dark Vision configuration will be loaded from environment variables.
Registering Speech to Text callback...
{"code":400,"code_description":"Bad Request","error":"unable to register callback url 'https://openwhisk.ng.bluemix.net/api/v1/web/myemail@ibm.com_space with spaces/vision/speechtotext', callback server responded with status code 505"}
Done

I reported an issue to the Speech to Text service which does not correctly handle spaces in URL. Seems this issue is still there. The Cloud Functions piece is working.

Did STT work for you?

sdague commented 7 years ago

You are right, this appears to be a bug in the Speech to Text service. I built a custom callback using a simple PHP script, and the moment I put spaces in the url encoded with either %20 or + they fail. You have a link to that bug? This would be a good thing to figure out why they don't support that.

l2fprod commented 7 years ago

thanks. I merged the fix for Cloud Functions in master