description property of cis_filter and cis_firewall_rule bugged

IBM-Cloud / terraform-provider-ibm

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs

Mozilla Public License 2.0

336 stars 645 forks source link

description property of cis_filter and cis_firewall_rule bugged #5378

Open pauljegouic opened 1 month ago

pauljegouic commented 1 month ago

We got the following error when the value of description is changed on both resource (even if cis_filter not displayed here)

Expected behaviour: I can set whatever string I want or don't fill this field

pauljegouic commented 1 month ago

Tested with 1.65.1 and 1.66.0-beta0

pauljegouic commented 1 month ago

@hkantare

hkantare commented 1 month ago

@arpit-srivastava-ibm why do we have validation on description field ?

arpit-srivastava-ibm commented 1 month ago

@arjunchauhanibm Please have a look and see if any changes are required here.

arjunchauhanibm commented 1 month ago

@pauljegouic This feature was released 3 years back and we were unaware of this bug. There was validation present on the description field.

I have removed the validation and created a PR for the same. https://github.com/IBM-Cloud/terraform-provider-ibm/pull/5382

@hkantare can you please review the PR. After making the changes i was able to create firewall rules with custom description. I have added the ss in the PR.