IBM-Cloud / terraform-provider-ibm

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs
Mozilla Public License 2.0
336 stars 645 forks source link

fix(CatalogManagement): remove deprecated arguments not supported in latest sdk #5405

Closed benbuchanan closed 2 weeks ago

benbuchanan commented 4 weeks ago

PR to remove deprecated catalog management offering fields. Newest SDK doesn't support these values anymore so they need to be removed.

Community Note

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccIBMCmOfferingSimpleArgs'
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccIBMCmOfferingSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmOfferingSimpleArgs
--- PASS: TestAccIBMCmOfferingSimpleArgs (33.84s)

make testacc TESTARGS='-run=TestAccIBMCmOfferingDataSourceSimpleArgs'
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccIBMCmOfferingDataSourceSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmOfferingDataSourceSimpleArgs
--- PASS: TestAccIBMCmOfferingDataSourceSimpleArgs (24.91s)
benbuchanan commented 4 weeks ago

@hkantare

benbuchanan commented 3 weeks ago

@hkantare Including additional fix in this PR to allow the required_resources field to be set on a version.

Testing output

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmVersionComplexArgs -timeout 700m
=== RUN   TestAccIBMCmVersionComplexArgs
--- PASS: TestAccIBMCmVersionComplexArgs (21.53s)