Add ibm_cbr_zone_addresses resource

mtbrandy commented 4 months ago

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMCbr'

=== RUN   TestAccIBMCbrRuleDataSourceBasic
--- PASS: TestAccIBMCbrRuleDataSourceBasic (12.50s)
=== RUN   TestAccIBMCbrRuleDataSourceAllArgs
--- PASS: TestAccIBMCbrRuleDataSourceAllArgs (11.93s)
=== RUN   TestAccIBMCbrZoneAddressesDataSourceBasic
--- PASS: TestAccIBMCbrZoneAddressesDataSourceBasic (10.37s)
=== RUN   TestAccIBMCbrZoneAddressesDataSourceMultiple
--- PASS: TestAccIBMCbrZoneAddressesDataSourceMultiple (11.08s)
=== RUN   TestAccIBMCbrZoneDataSourceBasic
--- PASS: TestAccIBMCbrZoneDataSourceBasic (10.58s)
=== RUN   TestAccIBMCbrZoneDataSourceAllArgs
--- PASS: TestAccIBMCbrZoneDataSourceAllArgs (11.10s)
=== RUN   TestAccIBMCbrRuleBasic
--- PASS: TestAccIBMCbrRuleBasic (10.72s)
=== RUN   TestAccIBMCbrRuleAllArgs
--- PASS: TestAccIBMCbrRuleAllArgs (23.31s)
=== RUN   TestAccIBMCbrZoneAddressesBasic
--- PASS: TestAccIBMCbrZoneAddressesBasic (26.35s)
=== RUN   TestAccIBMCbrZoneAddressesUpdate
--- PASS: TestAccIBMCbrZoneAddressesUpdate (38.00s)
=== RUN   TestAccIBMCbrZoneBasic
--- PASS: TestAccIBMCbrZoneBasic (9.97s)
=== RUN   TestAccIBMCbrZoneAllArgs
--- PASS: TestAccIBMCbrZoneAllArgs (19.64s)
PASS

mtbrandy commented 4 months ago

This PR requires github.com/IBM/platform-services-go-sdk version v0.64.4 or later.

There is a compatibility issue with that version of the SDK that is causing the current build failure. https://github.com/IBM-Cloud/terraform-provider-ibm/pull/5499 fixes that issue and, thus, that PR must be merged before this one.

mtbrandy commented 4 months ago

@hkantare This PR is now ready for review now that #5499 has been merged.

zhenwan commented 4 months ago

please make sure you do this manual test:

create address resource from terraform
delete the zone from outside of terraform, like CLI/UI/API
run terraform plan / apply

zhenwan commented 4 months ago

reviewed the PR, sent some comments directly to Matt

mtbrandy commented 4 months ago

please make sure you do this manual test:

create address resource from terraform

delete the zone from outside of terraform, like CLI/UI/API

run terraform plan / apply

Thanks, I have pushed a commit to fix an issue found during this test.

hkantare commented 4 months ago

Fix the conflicts in go.mod

IBM-Cloud / terraform-provider-ibm

Add ibm_cbr_zone_addresses resource #5505

Community Note