IBM-Cloud / terraform-provider-ibm

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs
Mozilla Public License 2.0
341 stars 671 forks source link

[D,R] Network Security Group #5726

Closed michaelkad closed 1 month ago

michaelkad commented 1 month ago

[R] Add NSG [R] Add NSG Action [R] Add NSG Member [R] Add NSG Member test [R] Add NSG Rule

Community Note

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkSecurityGroupBasic
--- PASS: TestAccIBMPINetworkSecurityGroupBasic (33.51s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupMemberBasic
--- PASS: TestAccIBMPINetworkSecurityGroupMemberBasic (90.58s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupsDataSourceBasic
--- PASS: TestAccIBMPINetworkSecurityGroupsDataSourceBasic (14.83s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupDataSourceBasic
--- PASS: TestAccIBMPINetworkSecurityGroupDataSourceBasic (15.99s)
PASS

 === RUN   TestAccIBMPINetworkSecurityGroupRuleBasic
--- PASS: TestAccIBMPINetworkSecurityGroupRuleBasic (36.51s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupRuleTCP
--- PASS: TestAccIBMPINetworkSecurityGroupRuleTCP (36.00s)
PASS
michaelkad commented 1 month ago

@VaishnaviGopal , @yussufsh and @hkantare please help with reviewing this pr.

hkantare commented 1 month ago

@michaelkad can we fix the conflict

michaelkad commented 1 month ago

@michaelkad can we fix the conflict

@hkantare conflicts fixed