fix(cloud-databases): Refactor tests Part 1 - Githubissues

IBM-Cloud / terraform-provider-ibm

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs

Mozilla Public License 2.0

341 stars 671 forks source link

fix(cloud-databases): Refactor tests Part 1 #5810

Closed lornakelly closed 3 days ago

lornakelly commented 4 days ago

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Ticket: https://github.ibm.com/compose/App/issues/1412

Refactoring acceptance tests is time consuming as running the tests takes a long time so refactoring bit by bit

Removed common test functions into new file and out of PG file
concatenate PG PITR test

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstancePostgresPITR'
=== RUN   TestAccIBMDatabaseInstancePostgresPITR
=== PAUSE TestAccIBMDatabaseInstancePostgresPITR
=== CONT  TestAccIBMDatabaseInstancePostgresPITR
--- PASS: TestAccIBMDatabaseInstancePostgresPITR (1266.04s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        1270.265s
...