fail if interface script not exist and add prepend DNS to dhclient.co…

IBM-ICP4D / cloud-pak-ocp-4

OpenShift 4.x deployment for Cloud Paks

20 stars 24 forks source link

fail if interface script not exist and add prepend DNS to dhclient.co… #38

Closed hughjfchen closed 1 year ago

hughjfchen commented 2 years ago

…nf if bastion is booting from DHCP.

Fix #36 #37

fketelaars commented 1 year ago

@hughjfchen There are a lot of commits in this PR. Please let me know if your intention is to contribute to this repo or if you want to maintain a fork.

hughjfchen commented 1 year ago

@fketelaars Actually, I'm not very sure now. Firstly, I just want to fix some issues but I've added a lot of features which I believe are useful to myself. But to be honest, it's not very clean if these features are also useful to others. For now, I'd maintain my fork separately.

fketelaars commented 1 year ago

@hughjfchen Thanks for the quick response. I will close the PR for now. If you believe there are defects in the current repo that you could resolve. Can you please make separate changes for that and send a PR? Good luck with the fork!