search

IBM-MIL / IBM-Ready-App-for-Insurance

Ready App that allows users to connect to a IoT sensor network within their home to manage the health of assets.
https://developer.ibm.com/open/ibm-ready-app-for-insurance
Other
26 stars 13 forks source link

Files in open source config should be properties files, not source files #9

Closed rajohns08 closed 8 years ago

rajohns08 commented 8 years ago

The open source config repo has bluemix-settings-development.js and bluemix-settings-production.js, but the open source config repo should not contain source code. The secret keys in these files should be extracted into a properties file which should be included in the open source config repo, and these source files should be included in our github repo (without the real keys). Also the development directory in open source config should contain only the bluemix-settings-development.js and the production directory should only contain the bluemix-settings-produciton.js instead of both directories containing both files.

rajohns08 commented 8 years ago

One of the keys contained in the files mentioned above is app secret. This actually brings to light a potentially bigger issue in that bluemix apps created today no longer have an app secret. The mobile cloud sdk and push sdk we are using REQUIRE an app secret. Thus unless there is some roundabout way of finding an app secret for new apps, teams cloning our repo hoping to get a working copy will be unsuccessful since they can't use the SDKs we are using. I have created a bluemix ticket asking about this with ticket #5377-12080727.