Closed a-matsuo closed 2 months ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 8607756967: | 0.0% |
Covered Lines: | 290 |
Relevant Lines: | 290 |
Overall looking good! Some comments after a first read:
Thank you for comments! I reflected those comments in the notebook. Could you please review it again?
Hello! Just did a closer read through!
One more thought: The text is rather verbose when compared to some other published tutorials, but I think this is useful with respect to learning about the methods within. May be worth considering future updates to leave out edu content for tutorials and include this in other edu sections.
Taking a closer look at how we could resolve the current conflict due to the dependence on qopt_best_practices
:
qopt_best_practices
A few comments:
QAOAAnsatz
circuit instance and (ii) applies the SATMapper to that cost_op, then (iii) rebuilds the QAOAAnsatz circuit with the permuted cost_op. From there on, you can do the swap strategies as usual.@a-matsuo I've made an example of how we could change this notebook to be approved and uploaded to the learning platform here. Please take a look and implement the same changes and any additional ones that you may think are needed.
Hello everyone, I have removed the dependency on the qopt-best-practice repository from the notebook. Could you please review it again?
Also, please remove this notebook from the folder if redundant
Thank you @miamico ! I fixed them. @pedrorrivero @nathanearnestnoble I have removed the dependency on the qopt-best-practice repository from the notebook. Could you please review it again?
Looks good -- good work @miamico and @a-matsuo !
Summary
Add a notebook that tells how to use a qaoa-specific transpiler which is useful for large QAOA circuits.
Details and comments
This notebook consists of the qaoa-specifc transpiler which is the swap strategy and initial mapping using SAT.