docs(notebooks): add QNN tutorial

IBM-Quantum-Technical-Enablement / quantum-enablement

IBM Quantum Engineering and Enabling Technologies

Apache License 2.0

26 stars 8 forks source link

docs(notebooks): add QNN tutorial #25

Open MeltemTolunay opened 3 months ago

MeltemTolunay commented 3 months ago

Summary

QNN training tutorial with QCNN ansatz

Details and comments

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9346411820

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 8708380490:	0.0%
Covered Lines:	290
Relevant Lines:	290

💛 - Coveralls

miamico commented 3 months ago

Very quick comment, let's move the notebook to the docs/notebooks folder

miamico commented 3 months ago

Other comments to address to make this in shape for a PR:

Try adding SPSA instead of COBYLA. The vanilla implementation is quite contained so it could be included in the notebook
Recast the notebook into the Qiskit Patterns framework (1. specify the classical problem and the quantum way to solve it, 2. optimize it for the hardware 3. execute, 4.post-process)
Add more details explaining what is happening in each cell, right now the explanations are very bare-bone

MeltemTolunay commented 2 months ago

I now added a gradient function with parameter shift rule, qiskit patterns formalism, code to run on hardware and more text explaining the code.

MeltemTolunay commented 1 month ago

New changes include:

ParameterVectorElements are ordered alphabetically. FeatureMap parameters now have a new parameter_prefix='a' to ensure that input and weight parameters are assigned in correct order.
Parameter shift rule for computing the gradients are verified.
Added a new function to compute the gradient of the MSE loss with respect to weight parameters.
Added new optimizer options. We can now select from a collection of gradient-free optimizers, gradient-based optimizers and SPSA.

In addition, Mirko's previous comments regarding SPSA, Qiskit Patterns framework, and cell explanations are fully addressed.