IBM-Quantum-Technical-Enablement / quantum-enablement

IBM Quantum Engineering and Enabling Technologies
Apache License 2.0
26 stars 8 forks source link

Approve content from `adapt-vqe` for upload to Learning Platform #32

Open nathanearnestnoble opened 2 months ago

nathanearnestnoble commented 2 months ago

Notebook

Adapt-VQE

Outcome

Approval to publish

Content description

This notebook is meant to showcase an end-to-end workflow for adapt-vqe for a chemistry based problem and a UCC operator pool.

Software requirements

Review criteria

Reviewers

@IBM-Quantum-Technical-Enablement/product

Additional comments

Notebook directly related to client requests -- approval of a limited release would be beneficial if deemed not ready for general audience

Code of conduct

javabster commented 2 months ago

fyi Kaelyn is working on some updates to this notebook in the qiskit/documentation repo, and it will be deployed to learning from that repo: https://github.com/Qiskit/documentation/pull/1195

nathanearnestnoble commented 2 months ago

Thank you Abby!

jyu00 commented 1 week ago

Found this in my backlog. From product perspective, it mostly looks good, but I have a few comments:

  1. Consider using local testing mode in qiskit-ibm-runtime in place of Qiskit's Estimator, if the eventual goal is to have users to run on real hardware, just to make it easier to transition from simulator to real.
  2. This line estimator = Estimator(session=Session(service, backend=backend), options=session_options) is highly problematic because it creates a new session, which is unnecessary as it's already inside a Session context. This new session is also not closed, and the user would get charged until the iTTL expires. I also don't understand why it's name session_options when those are options for the estimator, not for the session.