Issues with roles/playbooks

[aoyawale]

I have not tried in ansible core but, if you run this in awx/tower since it has stricter requirements, a lot of this fails. I noticed a lot of playbooks and tasks/main.yml files are missing - - - at the top making it auto fail the checks. They also have spaces issues at the playbook level were the roles are design. I haven't looked at all of them but, I noticed in a couple so far. This will cause issues with whoever runs them. https://docs.ansible.com/ansible/latest/user_guide/playbooks_intro.html

[aoyawale]

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/config_dns/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/tree/master/roles/config_fed_dir/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/add_system_alerts_rsyslog/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/common_handlers/handlers/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/bootstrap_local/vars/Linux.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/config_failover_cookie/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/tree/master/roles/config_fed_dir/tasks

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/config_ntp/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/config_policy_attachments/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/tree/master/roles/config_reverseproxy_aac

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/config_policyserver/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/config_reverseproxy_oauth/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/config_snmp_monitoring/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/create_keystore/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/create_mgmt_root_dir/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/create_mgmt_root_file/tasks/main.yml

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/create_reverseproxy/tasks/main.yml

[ram-ibm]

Output from yamllint is being used to fix the flagged issues. This is not going to be a perfect science - since there are issues being flagged on line sizes of variables that cannot be avoided.

[aoyawale]

https://github.com/IBM-Security/isam-ansible-collection/blob/master/roles/authenticate_policy_attachments/tasks/main.yml doesn't have a --- or a - name: or the module starting with a -. I added something to my PR https://github.com/IBM-Security/isam-ansible-collection/pull/26