search

IBM-Security / isam-ansible-roles

Ansible Custom Modules, Handlers and Tasks for ISAM. Requires "ibmsecurity" python package.
Apache License 2.0
24 stars 43 forks source link

Handlers don't use lmi_port variable #101

Open Eskotus opened 5 years ago

Eskotus commented 5 years ago

I noticed that when ever I use something other than 443 for lmi_port most of the handlers fail. Looks like they use a variable named "port" and passes it to lmi_port and if that is missing it omits the variable altogether causing the isam module to revert to default 443.

I changed port to lmi_port and it seems to pick up the lmi_port in vars files. I could put in a pull request about this unless there is some reason to use a different variable in the handlers.

ram-ibm commented 5 years ago

It used to be lmi_port - got changed recently. Yes that needs to be fixed.

Eskotus commented 5 years ago

So what would be the best workaround for transition phase before the new variable "port" is used in all roles? Include both variables in var files?

ram-ibm commented 5 years ago

Yes -please use both variables for now. I plan to change the port to lmi_port in the handlers. Have also reached out to the folks who made the change.