search

IBM-Security / isam-ansible-roles

Ansible Custom Modules, Handlers and Tasks for ISAM. Requires "ibmsecurity" python package.
Apache License 2.0
24 stars 43 forks source link

Order of handlers in startconfig #172

Open tombosmansibm opened 4 years ago

tombosmansibm commented 4 years ago

When running a play that includes network configuration to change the LMI management address, and that includes roles that call the "Commit Changes" handler, the appliance becomes unresponsive.

The source of this problem is the order of the handlers. "Commit Changes" is listed before "Commit Changes and Restart" , so is executed first, resulting in loss of connection. If the order is reversed, it would work.

Is there a reason against swapping the order ? I would think that if you have the need for a "Commit Changes and Restart", you'd want to have that executed always over a simple "Commit Changes" ?

ram-ibm commented 4 years ago

I dont see an issue with changing the order for those two handlers. I am not aware of a place where that may conflict.

tombosmansibm commented 4 years ago

https://github.com/IBM-Security/isam-ansible-roles/pull/187