search

IBM-Security / isam-ansible-roles

DEPRECATED Ansible Custom Modules, Handlers and Tasks for ISAM. Requires "ibmsecurity" python package.
Apache License 2.0
24 stars 43 forks source link

set_junction role calls the add junction function #46

Closed LouBea closed 6 years ago

LouBea commented 6 years ago

In the set_junction role the action being called in main.yml is:

action: ibmsecurity.isam.web.reverse_proxy.junctions.add

Is there a reason why it doesn't call the ibmsecurity.isam.web.reverse_proxy.junctions.set function?

And if there is what is the correct role to use to call the set junction?

As a sub-question, why would there be an add_junction role? From what I understand the set function does the idempotence check & calls add if needed. Why would someone want to use add directly instead of using set?

Thanks !!

ram-ibm commented 6 years ago

It should be calling set() - I am wondering if I need to submit a merge. I see it in my local repository.

ram-ibm commented 6 years ago

Actually I dont - this needs to be fixed.

sygilber commented 6 years ago

Resolved with https://github.com/IBM-Security/isam-ansible-roles/pull/49