search

IBM-Security / isam-ansible-roles

Ansible Custom Modules, Handlers and Tasks for ISAM. Requires "ibmsecurity" python package.
Apache License 2.0
24 stars 43 forks source link

Add new Point of Contact role #68

Closed sygilber closed 6 years ago

sygilber commented 6 years ago

Will contibute a new role for adding a Point of Contact. It is only this week that we found why one wound want to create a new poc.

For now I have named it 'update_point_of_contact'. Of course it could be named also 'add_point_of_contact' but what I want to prevent is that we push the 2 version of the role 'add and update'. I check the ibmsecurity implementation and it supports both adding/updating when invoking the 'ibmsecurity.isam.fed.point_of_contact.set' method. Ansible is about idempotency and so we should not have to decide which add/update role to invoke when developping playbook.

Also, I am unsure if it should be commited right away in the new structure (base|aac|fed|web) commited last week. And if so, if it should fall under fed or aac category. Theorically it is bound to "fed" rest-api but it is used in both AAC and FED modules (LMI menus).

Comments welcomed.

ram-ibm commented 6 years ago

Please note that the idea behind set() was to avoid having to chose update() versus add(). Since it does one or the other intelligently. I suggest using set() or set_current() provided right now. It has been created in the "fed" directory.

ram-ibm commented 6 years ago

FYI - the new role structure uses a different methodology - you are welcome to continue using the current role naming convention if that suits your purpose better.

sygilber commented 6 years ago

Close by https://github.com/IBM-Security/isam-ansible-roles/pull/69

Thanks