search

IBM-Swift / swift-buildpack

IBM Cloud buildpack for Swift
BSD 3-Clause "New" or "Revised" License
32 stars 31 forks source link

complete test coverage #92

Closed christiancompton closed 7 years ago

christiancompton commented 7 years ago

Increased test coverage to 100%

screen shot 2017-06-27 at 5 40 23 pm

christiancompton commented 7 years ago

@rolivieri: When working with @degrim yesterday, we discussed refactoring some of the logic inside if proxy_required since the flow is only different if proxy is required and the index is not the first one. What are your thoughts?

rolivieri commented 7 years ago

@christiancompton Before we can merge this PR, can you ensure that the corresponding builds are passing? See this:

https://travis-ci.org/IBM-Swift/swift-buildpack/builds/247982808 https://travis-ci.org/IBM-Swift/swift-buildpack/builds/247985820

You are running into the same issue I shared with you yesterday. You may want to merge develop into your branch and then do a PR against develop. That way you will get the fixes I made over the weekend.

itzunagi commented 7 years ago

@rolivieri it looks like the test ran into the intermittent staging issues we've been seeing in that env today, everything else looks good to me.