Datastore/storage cluster names with white spaces is not handled by provider

[rachappag]

Issue Description

• Created a terraform vsphere provider pattern to boot a VM by specifying a datastore (having white spaces in the name).

• But terraform apply operation failed while processing the disk path.

• However vsphere client and govc/govmomi successfully boots VM using datastore having white spaces in the name.

Root Cause

• It is an inability of terraform to handle white space in the datastore name
• Terraform is trying to extract the disk path from the vsphere datastore path.
• Syntax of vsphere datastore path: "[DataStore Name] VirtualMachineName/VirtualMachineName.vmdk"
• The above string is being split on " " character to extract the VM disk path.
• Hence the disk path string is splitted wrongly when there is a space in the datastore name.

Open Issue with fix available in the terraform Community:

• The open issue addressing this is: https://github.com/hashicorp/terraform/pull/9174
• The issue has been fixed by applying regex patters to match and extract the substrings.
• Fix is commited but not yet merged with master.

Drawback of regex pattern solution:

• The regular expression again confined to the syntax of vsphere full disk path representation.
• The regex will also fail if there is any change in the syntax of vsphere full disk path representation.

Update/Enhancement added by govmomi to address this Issue:

• The govmomi has provided the fix in the release "govmomi v0.12.1".
• The govmomi has added a helper utility function to parse the datastore path.

Proposed Solution/Fix in Terraform:

• Modify terraform code to use the helper utility function provided by govmomi to parse the datastore path.