search

IBM / Ansible-OpenShift-Provisioning

Automate the deployment of Red Hat OpenShift Container Platform on IBM zSystems (s390x). Automated User-Provisoned Infrastructure (UPI) setup using Kernel-based Virtual Machine (KVM).
https://ibm.github.io/Ansible-OpenShift-Provisioning/
MIT License
20 stars 44 forks source link

Separation mirror vars #313

Closed AmadeusPodvratnik closed 3 months ago

AmadeusPodvratnik commented 3 months ago

feat: Move disconnected variables out of all.yaml for better usability.

AmadeusPodvratnik commented 3 months ago

@mohammedzee1000 Could you pls have a look, too. Thx in advance.

veera-damisetti commented 3 months ago

Looks good to me @mohammedzee1000 can you please add your view also here thanks

mohammedzee1000 commented 3 months ago

Code wise looks good But i have one doubt. Have we tried running this when someone does not create disconnected.yaml? I would assume the disconnected.enabled checks in the 0_setup playbook would fail in such case @AmadeusPodvratnik

AmadeusPodvratnik commented 3 months ago

Code wise looks good But i have one doubt. Have we tried running this when someone does not create disconnected.yaml? I would assume the disconnected.enabled checks in the 0_setup playbook would fail in such case @AmadeusPodvratnik

Hi @mohammedzee1000 , thank you! Yes I made a mistake by adding a template instead of the yaml itself. Disconnected must be handled as default values (due to the pure nature how it's integrated). We can think about to have a variable inside of all.yaml but basically we do not need a template for disconnected.

AmadeusPodvratnik commented 2 weeks ago

:tada: This PR is included in version 2.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: