Closed Tomcli closed 7 years ago
@ljbennett62 please get this pulled in
@Tomcli @animeshsingh - it looks like this change breaks the build
It looks like you are issuing the command "git clone -b master https://$GITHUB_USER:$GITHUB_PWD@github.com/IBM-Swift/Testing-Credentials.git" and it is failing because it should be IBM-Swift - it should be from the IBM org.
I think the build is failing because it's missing the credential from Travis environment variable. Since our branch is not in this repository, the PR build won't have access to GITHUB_USER
and GITHUB_PWD
.
Is it possible for you to create a new branch to test the build with this change?
@Tomcli @ljbennett62 what`s holding this at this point - seems legit to me
@animeshsingh @Tomcli - the build is failing because the problem is that because it is an external PR. Travis CI won't make the credentials available to the build job when building external PRs.
We need to manually merge that PR locally on a macOS into a branch that one creates off master... and then push that branch to github. Then that build will run as usual and then one can do a PR from that branch into master.
Moved to #421
We would like to have this journey also sent metrics to our new tracker to see its behavior.
cc: @animeshsingh