CAST can enhance the system management of cluster-wide resources. It consists of the open source tools: cluster system management (CSM) and burst buffer.
After investigating, these warnings appear to be safe to ignore. The warning is to let us know that we may be leaving the destination memory region without a NULL terminator in the case where the source string is larger than the destination. However, we explicitly add a NULL terminator immediately following the calls to strncpy to handle this scenario, like this:
This same logic is used in other areas of the code without generating the warning above, but there seem to be some subtle differences related to whether the source is a char * or a char [], which may be a factor that influences whether the warning is triggered.
Reducing the length of the strncpy by 1 and continuing to explicitly set the last char to a NULL causes the warning to stop being reported, so I have updated the code to use this logic. These are functionally equivalent as long as the explicit NULL terminator is added, which is needed in any case to handle the case of truncation anway.
I then tested to make sure no truncation or other differences were detected in the collected inventory information and all of the data was the same:
(Note: the purpose of cat -A was to add non-printable characters to the output to make sure there weren't any hidden differences being inserted accidentally. This causes the $ chars to appear at the end of each line, for example.)
When building CSM on RHEL 8, the following warnings are reported that are not reported when building on RHEL 7:
After investigating, these warnings appear to be safe to ignore. The warning is to let us know that we may be leaving the destination memory region without a NULL terminator in the case where the source string is larger than the destination. However, we explicitly add a NULL terminator immediately following the calls to
strncpyto handle this scenario, like this:This same logic is used in other areas of the code without generating the warning above, but there seem to be some subtle differences related to whether the source is a
char *or achar [], which may be a factor that influences whether the warning is triggered.Reducing the length of the strncpy by 1 and continuing to explicitly set the last char to a NULL causes the warning to stop being reported, so I have updated the code to use this logic. These are functionally equivalent as long as the explicit NULL terminator is added, which is needed in any case to handle the case of truncation anway.
I then tested to make sure no truncation or other differences were detected in the collected inventory information and all of the data was the same:
(Note: the purpose of
cat -Awas to add non-printable characters to the output to make sure there weren't any hidden differences being inserted accidentally. This causes the$chars to appear at the end of each line, for example.)Before the change:
After the change: