IBM / GameOn-Java-Microservices-on-Kubernetes

This code demonstrates deployment of a Microservices based application Game On! on to Kubernetes cluster. Game On! is a throwback text-based adventure built to help you explore microservice architectures and related concepts.
https://developer.ibm.com/patterns/deploy-java-microservices-on-kubernetes-with-polyglot-support/
Apache License 2.0
95 stars 72 forks source link

use official images, or an official IBM docker repo. #14

Closed paulczar closed 7 years ago

paulczar commented 7 years ago

Some of the images in this repo are unofficial, and sometimes not even automated builds so you can't click back to see the authenticity/makeup of the image. We should ensure that all images are either the official ones from docker ( or the software maker ) or part of an IBM docker repo with automated build etc turned on.

We should also pin them where possible to specific versions to help reduce the chance of upstream changes breaking the demo.

Here are some examples gathered from the k8s manifest files in the repo ... this is not all, just a few from a quick dig through:

keystore

This one is unpinned and is from a personal repo with no automated build or other information to show where it came from and if its authentic. It would be better if it came from an IBM docker repo and was pinned.

kafka

This one is also unpinned and from a personal repo, its a year old and is not automated build and has no details on where to find the origin dockerfile etc.

There does not appear to be an official image, however there are several that appear to have a good well known author/source:

couchdb

This one is pinned and has autobuild on, but if possible would be better to use the official repo

https://hub.docker.com/r/klaemo/couchdb/

AnthonyAmanse commented 7 years ago

Created pull request #15

  1. keystore - was using the Dockerfile in containers/setup/. Added reference in main README in pr
  2. couchdb - is now using image from official repo

Will be testing another kafka image

animeshsingh commented 7 years ago

Done