IBM / GameOn-Java-Microservices-on-Kubernetes

This code demonstrates deployment of a Microservices based application Game On! on to Kubernetes cluster. Game On! is a throwback text-based adventure built to help you explore microservice architectures and related concepts.
https://developer.ibm.com/patterns/deploy-java-microservices-on-kubernetes-with-polyglot-support/
Apache License 2.0
95 stars 72 forks source link

maybe switch out changeable IPs from k8s manifests to easier pattern #16

Closed paulczar closed 7 years ago

paulczar commented 7 years ago

if we switch it out for a string like xxxIPxxx then its easier to replace ... the following would be on linux ... I think the sed command is different on mac:

sed -i 's/xxxIPxxx/169......./' core/*.yaml

          - name: FRONT_END_PLAYER_URL
            value : https://169.47.241.213:30443/players/v1/accounts
          - name: FRONT_END_SUCCESS_CALLBACK
            value : https://169.47.241.213:30443/#/login/callback
          - name: FRONT_END_FAIL_CALLBACK
            value : https://169.47.241.213:30443/#/game
          - name: FRONT_END_AUTH_URL
value : https://169.47.241.213:30443/auth

becomes

          - name: FRONT_END_PLAYER_URL
            value : https://xxxIPxxx:30443/players/v1/accounts
          - name: FRONT_END_SUCCESS_CALLBACK
            value : https://xxxIPxxx:30443/#/login/callback
          - name: FRONT_END_FAIL_CALLBACK
            value : https://xxxIPxxx:30443/#/game
          - name: FRONT_END_AUTH_URL
            value : https://xxxIPxxx:30443/auth
AnthonyAmanse commented 7 years ago

Done #21