search

IBM / JSONata4Java

Open Source Java version of JSONata
Apache License 2.0
88 stars 36 forks source link

Add upper/lower presentation format for am/pm in fromMillis #277

Closed alexwoodgate closed 8 months ago

alexwoodgate commented 9 months ago

Fixes #276

Fix is based on the original JSONata fix, (https://github.com/jsonata-js/jsonata/pull/644) basically just removed the extra = from === as the code is consistent between the JS and Java versions.

Updates $fromMillis() function to support am/pm PN presentation format to output AM/PM and adds test cases for PN and Pn (existing test case for default presentation covers just P).

alexwoodgate commented 8 months ago

@wnm3 What was the reason this PR was closed? Any issue with the fix or additional changes needed?

wnm3 commented 8 months ago

Hmm, I thought it has been accepted. I can reopen...

wnm3 commented 8 months ago

I'm releasing v2.4.5 today -- will be in Maven in a few hours. Sorry for the confusion.

alexwoodgate commented 8 months ago

Thanks for sorting it so quickly.