Closed jasonkatonica closed 3 months ago
Could you add the sign-off
to satisfy the DCO check?
Could you add the sign-off to satisfy the DCO check?
I was missing a signoff on one of my 3 commits. I just did a rebase into a single commit which should fix the DCO issue.
LGTM
A intermittent problem has been observed as follows:
Key encodings that have been encountered for XDH based keys include:
Case 1 above occurs when keys are encoding from the SunEC provider on releases older then Java 17.
Case 2 above occurs when keys are generated by OpenJCEPlus or the SunEC provider on Java 17 or higher.
The encoding logic was updated to fix a corner case where a random key value contained a nested octet string just by chance. When this occured a key value was parsed that was not the correct length causing the above bad key specification when the key bytes were formatted for use with the Open Cryptography Kit C library. This update checks that key lengths are correct after parsing a nested octet string. If the length is not correct we will attempt to use a single octet format encoding.
An additional interoperability test was added to perform XDH encoding works with encoding produced by the SunEC provider for X448 and X25519 named curves.
The CurveUtil class was simplified to store known key sizes and known der encoding sizes for a given named curve.