search

IBM / OpenJCEPlus

This project makes use of Java and C/C++. This project will create OpenJCEPlus and OpenJCEPlusFIPS cryptographic providers which are implementations of the Java™ Cryptography Extensions (JCE) APIs. The actual cryptographic code will come from the OpenCryptographyKitC project which is based on OpenSSL.
Apache License 2.0
3 stars 10 forks source link

Update initialize function name #78

Closed johnpeck-us-ibm closed 2 months ago

johnpeck-us-ibm commented 3 months ago

Updates the initialize function to include package name to be unique. Other functions look to be okay and not likely for a collision.

Tested winx64

Fixes: https://github.com/IBM/OpenJCEPlus/issues/76

Signed-off-by: John Peck johnpeck@us.ibm.com

KostasTsiounis commented 3 months ago

I think we should put the Fixes: https://github.com/IBM/OpenJCEPlus/issues/76 in the description, instead of the title of the PR.

jasonkatonica commented 2 months ago

x86_64_linux

johnpeck-us-ibm commented 2 months ago

I think we should put the Fixes: https://github.com/IBM/OpenJCEPlus/issues/76 in the description, instead of the title of the PR.

Hi Kostas, Lets do the following: Add the issue number to the title of the PR, but the link into the description and link the PR to the issue. This way it is easy to find the related 76 for a PR and if someone for forgets one of the above. At least we have the others. Also, with the issue number in the PR it is easy to find related PR when looking for support issues etc.

mstoodle commented 2 months ago

I'll lob in a comment from the sidelines :) : the issue already gets a comment added with a link to any commit with the Fixes: line in the description once the commit is added to a branch or merged. That seems like the most convenient way to connect issues to code changes, so long as contributors/reviewers are diligent about making sure the Fixes: line is there.

KostasTsiounis commented 2 months ago

Mark is right. Once we add the Fixes: line, a link to the PR is created automatically like a comment. Thus, you can always search the issues, find the one you want and go to the associated PR. So, there is no need for a manual link on the issue side. We usually don't include the issue number in the PR title, since you can get there through the actual issue, but I'm OK if you want to keep it there.

johnpeck-us-ibm commented 2 months ago

That works for me.