search

IBM / OpenWhisk-on-Kubernetes

This code demonstrates the deployment of OpenWhisk on Kubernetes cluster from Bluemix container service
Apache License 2.0
33 stars 20 forks source link

Run all Travis tests on each event #18

Closed mlangbehn closed 7 years ago

mlangbehn commented 7 years ago

Previously, we were not running our full test suite on each event sent to Travis.

Now, our .travis.yml has been tidied and configured to run both tests in parallel.

Signed-off-by: Matt Langbehn matthew.langbehn@gmail.com

Tomcli commented 7 years ago

The reason I created the script just for PR is because PR can't access my environment variables. So I don't think is a good idea to run both tests for PR.

mlangbehn commented 7 years ago

@Tomcli: It would be a really good idea for us to get testing working on pull requests. Only checking the master branch kind of defeats the purpose of CI.

Let's work to figure out a solution.

Tomcli commented 7 years ago

I don't think we should expose any environment variable because PR can manipulate Travis to expose them. Therefore, we should find a way to let the PR person to provide his/her cluster for Travis in PR.

You can find more detail on Travis PR from this link - https://docs.travis-ci.com/user/pull-requests/

mlangbehn commented 7 years ago

@Tomcli: While I agree with not exposing more than we need to, one major issue with Travis CI is that it does not allow proper gating of projects.

What I mean by this is that if we only have full testing occurring on master, we will not be able to catch issues causing failures in Bluemix deploys until the commit has already merged.

I will put this pull request on hold while I continue my work getting minikube to work, but we will need to readdress it later.

mlangbehn commented 7 years ago

Closing. Will open another pull request to address our need to test all pull requests.