search

IBM / ansible-for-i

the tool is to provide several customized modules for Ansible to manage IBM i systems.
GNU General Public License v3.0
56 stars 54 forks source link

ibmi_synchronize_files.py cannot find ibmi_sync_files.py #205

Open MexCFood opened 4 months ago

MexCFood commented 4 months ago

With the change to absolute pathing and the removal of collections: ibm.power_ibmi, a call to ibmi_synchronize_files fails with message "The module ibmi_sync_files was not found in configured module paths"

Absolute pathing should either be added into "ansible-for-i-devel\plugins\action\ibmi_synchronize_files.py" line 83, or collections: ibm.power_ibmi should be added back into certain playbooks (such as ansible-for-i-devel\usecases\fix_management\sync_apply_individual_ptfs_lv1.yml.)

Thanks!

robgjertsen1 commented 3 months ago

OK, thanks for letting me know. I haven't seen this in my testing such as with the use case playbook sync_apply_individual_ptfs_lv1.yml, which I tested a couple of months ago.

We are now required to use the fully qualified collection names (FQCN) with modules in Ansible to retain certification with Redhat (to pass with the code checking tool). I believe the checking tool also complained about the use of the collections keyword which was why "collections:" was removed. Leaving the only option as updating plugin python files to use the fully qualified name if we need to adjust this. Interesting that this would break things from using "collections:" with unqualified name to using fully qualified name without collections keyword.

Just wondering if there is an environmental difference. Do you have the following in your ansible config file?

library=~/.ansible/collections/ansible_collections/ibm/power_ibmi/plugins/modules action_plugins=~/.ansible/collections/ansible_collections/ibm/power_ibmi/plugins/action

MexCFood commented 3 months ago

Hey Rob, my pleasure - thanks for looking into it. That makes sense as to why it was removed.

We are using the automation platform, with an ibmi specific execution environment built through ansible-builder. I do not see that line in my Ansible cfg file. With that in mind, I am looking into where it gets the path in an EE at all 😃

MexCFood commented 3 months ago

Okay - so our ee is just looking in the default location /usr/share/Ansible/collections/ansible_collections. we do not have any other specific environment variables pointing to this module, so I assume we rely on the FQN (or the collections call) to find where in the path to look (/ibm/power_ibmi/plugins/modules/ibmi_sync.py).

robgjertsen1 commented 2 months ago

Seeing if you were able to resolve this issue.

MexCFood commented 2 months ago

Hey Rob - thanks for following up. I was able to circumvent it by adding the collections statement to a custom version of sync_apply_individual_ptfs_lv1.yml so this is not causing me a problem at this time. I do expect it would still be an issue otherwise, as the plugins/action/ibmi_synchronize_files.py file is referencing the module 'ibmi_sync_files' without FQCN.

On Tue, Aug 27, 2024 at 8:37 AM Rob Gjertsen @.***> wrote:

Seeing if you were able to resolve this issue.

— Reply to this email directly, view it on GitHub https://github.com/IBM/ansible-for-i/issues/205#issuecomment-2312901537, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJUNQNF7A2OTCUAWZ26Z45LZTSMKLAVCNFSM6AAAAABKKB3JC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJSHEYDCNJTG4 . You are receiving this because you authored the thread.Message ID: @.***>