IBM / ansible-power-aix

Developer contributions for Ansible Automation on Power
https://ibm.github.io/ansible-power-aix/
GNU General Public License v3.0
80 stars 93 forks source link

Localpatchserver patch: #523

Closed ptsiamis closed 1 month ago

ptsiamis commented 1 month ago

Includes the abillity to local clone in an http server the packages from ibm ifix thus avoiding the usage of internet/proxy in the aix systems. The method is simple you specify your server and the path of the patches and the flrtvc module replaces the urls from flrtvc.ksh to the desired local ones. It will need of course to be set with apar_csv in order to find a local copy of apar.csv. See demo playbooks for this.

nitismis commented 1 month ago

@schamola , please review this PR

schamola commented 1 month ago

Hi @ptsiamis, Please provide the output for your changes.

Moreover, there are some linting issues in the code because of which the PR is failing, you need to fix them: https://github.com/IBM/ansible-power-aix/actions/runs/8921637052/job/24579867040?pr=523

ptsiamis commented 1 month ago

Hey i commited an update that includes pep8 validation without the 79 chars limit, can you see my commit or i need to do something more to apply for this pull request? thanks

ptsiamis commented 1 month ago

Any update on this ? thanks

schamola commented 1 month ago

Hi @ptsiamis There's still one linting issue, that requires fixing: https://github.com/IBM/ansible-power-aix/actions/runs/9017753806/job/24811089028?pr=523

Moreover, please provide the output for the changes that you have made.

ptsiamis commented 1 month ago

Hey i have pushed an new commit on the pull request you dont see the changes from there? I am new on this collaboration tool so have little patience :)

schamola commented 1 month ago

@ptsiamis Yes, your changes are visible, but still one linting issue is there. Moreover, we need to see the output before merging your changes so as to know that it is working as per the expectations. So, please provide the output too.

ptsiamis commented 1 month ago

Hey, @schamola So when you say output you mean i have to upload a test play of this changes that shows how its running and what it do? Thanks Panos

schamola commented 1 month ago

Yes @ptsiamis , test play (play recap). And also, please fix the linting issue as well... It is a very minor change.

ptsiamis commented 1 month ago

Hey i fixed in my latest commit the lint issue , i attach a run of my update. what it basically does is that when you dont have internet access direct or through proxy from your aix hosts you create a local webserver that has access to the internet and the aix servers have access to this server like a simpler redhat satellite. it does it by taking the original urls of the patches founded in apar.csv and modify them to the be retrieved from the custom url and path you have provided as arguments on the task run. it also let you define a custom url for FLRVT-Latest.zip in order to download it also from your internal web server. flrvt_update_ifix.log

Thanks panos

ptsiamis commented 1 month ago

Hey @schamola any update on this? i have fixed the lint issue and provided the recap. thanks for your patience

schamola commented 1 month ago

Hey @ptsiamis we are still looking into it. Thanks !

ptsiamis commented 1 month ago

Thanks, if you need any help to demonstrate it i can assist you !

Panayotis Tsiamis Systems / Software Engineer Mobile: +30 694 25 23 223 Εmail: @.*** Linkedin: http://www.linkedin.com/in/ptsiamis

Στις Παρ 17 Μαΐ 2024 στις 2:38 μ.μ., ο/η Shreyansh Chamola < @.***> έγραψε:

Hey @ptsiamis https://github.com/ptsiamis we are still looking into it. Thanks !

— Reply to this email directly, view it on GitHub https://github.com/IBM/ansible-power-aix/pull/523#issuecomment-2117406532, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMWZ6Y2MC2OCQ2HUNM3OADZCXT47AVCNFSM6AAAAABHDLHIXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJXGQYDMNJTGI . You are receiving this because you were mentioned.Message ID: @.***>

ptsiamis commented 1 month ago

Glad to hear it! hope we will merge it in next release

On Mon, May 20, 2024, 15:16 Shreyansh Chamola @.***> wrote:

@.**** approved this pull request.

Hi @ptsiamis https://github.com/ptsiamis, Your changes seem to be working fine on our environment as well. Great work !

— Reply to this email directly, view it on GitHub https://github.com/IBM/ansible-power-aix/pull/523#pullrequestreview-2066093465, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMWZ6YPNBIHZPMY3BECIBTZDHSSXAVCNFSM6AAAAABHDLHIXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRWGA4TGNBWGU . You are receiving this because you were mentioned.Message ID: @.***>