IBM / ansible-power-aix

Developer contributions for Ansible Automation on Power
https://ibm.github.io/ansible-power-aix/
GNU General Public License v3.0
80 stars 93 forks source link

Fix for idempotency issue in filesystem #532

Closed schamola closed 3 weeks ago

schamola commented 3 weeks ago

Fix for issue #402

nitismis commented 3 weeks ago

@schamola, Please fix the linting issue.

rseabra commented 3 weeks ago

Hi @schamola , why are you turning truthy values into strings and lists of strings? I couldn't understand the advantage looking at the diff and that seems like a major breakage of compatibility for no reason.

schamola commented 3 weeks ago

Hi @rseabra, these changes were made for ease of comparison with the already existing values. Moreover, during command creation inside the module, the boolean values were anyways being replaced by "yes" and "no" only at the end.